Bug 2117268: api-resource-collector: Don't attempt to parse empty Ignition

[jhrozek]

While filtering files out of MachineConfigs, we tried to also parse
ignition specification of MachineConfigs that didn't specify any,
leading to an error.

Let's just pass on MCs that don't have any Ignition spec as-is.

Resolves: rhbz#2117268

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhrozek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jhrozek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jhrozek: This pull request references Bugzilla bug 2117268, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 2117268: api-resource-collector: Don't attempt to parse empty Ignition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jhrozek]

/hold
for QE review

[jhrozek]

/test e2e-aws

[jhrozek]

/test e2e-aws

[jhrozek]

@xiaojiey PTAL if this fixes the bug
@mrogers950 @rhmdnd @Vincent056 PTAL from code perspective

[mrogers950]

/lgtm

[jhrozek]

@sheriff-rh I added a CHANGELOG blob to the PR, is it sufficient for you to base a release note on? If yes, can you add the docs-approved label?

[jhrozek]

@mrogers950 sorry, I forgot to add a changelog blob earlier, so the latest push ended up removing the lgtm label. Can you re-add it please? There are no other changes.

[xiaojiey]

/bugzilla cc-qa

[openshift-ci]

@xiaojiey: This pull request references Bugzilla bug 2117268, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @xiaojiey

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[xiaojiey]

/label qe-approve

[sheriff-rh]

lgtm, thanks @jhrozek

[jhrozek]

Since this is a bug, I'm adding the px-approved label myself
/label px-approved

[jhrozek]

/hold cancel

[Vincent056]

sorry for the late review,
/lgtm

[jhrozek]

@mkumku see this PR for px-approved

[mrogers950]

/lgtm

[openshift-ci]

@jhrozek: All pull requests linked via external trackers have merged:

• ComplianceAsCode/compliance-operator#81

Bugzilla bug 2117268 has been moved to the MODIFIED state.

In response to this:

Bug 2117268: api-resource-collector: Don't attempt to parse empty Ignition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.