OCP4: Fix pr image workflow #11533
Merged
OCP4: Fix pr image workflow #11533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
We don't have a way to test this workflow until we have this merged |
yuumasato
requested changes
Feb 2, 2024
There was a problem hiding this comment.
@Vincent056 Would you like to incorporate these from https://github.com/ComplianceAsCode/content/pull/11531/files ?
rhmdnd
reviewed
Feb 2, 2024
Vincent056
force-pushed
the
fix_pr_image_workflow
branch
from
5c04c0b
to
c287b14
Compare
There was a issue with existing pr image build workflow, github does not let workflow to use metal-toolbox/container-push/.github/workflows/container-push.yml@main in the steps, this PR replace metal-toolbox to build and push image directly
Vincent056
force-pushed
the
fix_pr_image_workflow
branch
from
c287b14
to
7d9ba83
Compare
|
Code Climate has analyzed commit 7d9ba83 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.3% (0.0% change). View more on Code Climate. |
|
This PR should not be affecting any build or test in centos-stream-9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with the existing pr image build workflow, GitHub does not let workflow use metal-toolbox/container-push/.github/workflows/container-push.yml@main in the steps, this PR replaced metal-toolbox to build and push images directly.