-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update action workflows on PR image generation #496
Conversation
Update the worflow to build image for each PR, so image can be built even when PR is created from a fork.
this needs metal-toolbox/container-push#68 to work |
echo "::set-output name=image-tags::${image_tags}" | ||
id-token: write | ||
packages: write | ||
uses: metal-toolbox/container-push/.github/workflows/container-push.yml@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't we run into issues with metal-toolbox/container-push
and workflow_run
?
ComplianceAsCode/content#11533
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a fix in metal-toolbox/container-push#68
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependent patch looks good. Let's see how this works once it's merged.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update the action to build image for each PR, so image can be built even when PR is created from a fork.