Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --datastream-only in ./build_product #10020

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jan 3, 2023

Description:

Fixes --datastream-only.

Rationale:

Allow use of --datastream-only .

Review Hints:

If you run ./build_product --datastream-only on master (772d932) you should get

make: *** No rule to make target 'generate-ssg-ALINUX2-ds.xml'. Stop.

@Mab879 Mab879 added bugfix Fixes to reported bugs. Infrastructure Our content build system labels Jan 3, 2023
@Mab879 Mab879 added this to the 0.1.66 milestone Jan 3, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jan 3, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 3, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions
Copy link

github-actions bot commented Jan 3, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 marked this pull request as ready for review January 3, 2023 18:51
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jan 3, 2023
@Mab879
Copy link
Member Author

Mab879 commented Jan 4, 2023

/packit build

@jan-cerny jan-cerny self-assigned this Jan 4, 2023
@jan-cerny
Copy link
Collaborator

I got this error:

[jcerny@thinkpad scap-security-guide{pr/10020}]$ ./build_product --datastream-only 
./build_product: line 300: generate-ssg-${$chosen_product | tr '[:upper:]' '[:lower:]'}-ds.xml: bad substitution

then, the build started

@Mab879
Copy link
Member Author

Mab879 commented Jan 4, 2023

I got this error:

[jcerny@thinkpad scap-security-guide{pr/10020}]$ ./build_product --datastream-only 
./build_product: line 300: generate-ssg-${$chosen_product | tr '[:upper:]' '[:lower:]'}-ds.xml: bad substitution

then, the build started

I just pushed an update that should fix that.

@codeclimate
Copy link

codeclimate bot commented Jan 4, 2023

Code Climate has analyzed commit 79b8fbd and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.8% (0.0% change).

View more on Code Climate.

Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. I tried to run the build_product script with --datastream-only both with and without specifying a product name. In both cases it worked for me as expected. I also don't experience the error message I mentioned above.

@jan-cerny jan-cerny merged commit 9808c53 into ComplianceAsCode:master Jan 5, 2023
@Mab879 Mab879 deleted the fix_datastream_only branch January 5, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes to reported bugs. Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants