Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accounts_password template for OL #10045

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jan 10, 2023

Description:

Fix a minor syntax issue.

Rationale:

This was causing invalid syntax errors for OL8 Ansible and nightly build failures.

Review Hints:

Running ctest --output-on-failure -R ansible-playbook-syntax-check-ol8 on master should show the error.

This was causing invalid syntax and nightly build failures.
@Mab879 Mab879 added bugfix Fixes to reported bugs. Ansible Ansible remediation update. Oracle Linux Oracle Linux product related. labels Jan 10, 2023
@Mab879 Mab879 added this to the 0.1.66 milestone Jan 10, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Jan 10, 2023

Code Climate has analyzed commit 5ec74b2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.9% (0.0% change).

View more on Code Climate.

@Mab879
Copy link
Member Author

Mab879 commented Jan 10, 2023

/retest

Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks @Mab879 .

@marcusburghardt marcusburghardt merged commit 5c9c90f into ComplianceAsCode:master Jan 11, 2023
@Mab879 Mab879 deleted the fix_ol_ansible_for_nightly_build branch January 11, 2023 13:09
@marcusburghardt marcusburghardt self-assigned this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ansible Ansible remediation update. bugfix Fixes to reported bugs. Oracle Linux Oracle Linux product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants