Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update link to NTP docs #10056

Merged
merged 2 commits into from
Jan 13, 2023
Merged

Update link to NTP docs #10056

merged 2 commits into from
Jan 13, 2023

Conversation

yuumasato
Copy link
Member

@yuumasato yuumasato commented Jan 13, 2023 •
edited

Description:

  • Fixed docs link for Fedora NTP config with chrony
  • Added links to docs how to configure NTP using chrony for RHEL8 and RHEL9.
    • They were still using links to RHEL7.

Rationale:

  • The link to rawhide doesn't work anymore.

@yuumasato
Fix broken link for Fedora NTP docs
231c7d6 
The link to rawhide doesn't work anymore.
@yuumasato yuumasato added this to the 0.1.66 milestone Jan 13, 2023
@yuumasato
Add link to using Chrony to configure NTP
12e5ec7 
RHEL8 and RHEL9 link were missing.
@yuumasato yuumasato changed the title Fix broken link for Fedora NTP docs Fix link to NTP docs Jan 13, 2023
@codeclimate
Copy link

codeclimate bot commented Jan 13, 2023

Code Climate has analyzed commit 12e5ec7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.8% (0.0% change).

View more on Code Climate.

@openshift-ci
Copy link

openshift-ci bot commented Jan 13, 2023

@yuumasato: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-rhcos4-moderate 12e5ec7 link true /test e2e-aws-rhcos4-moderate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 self-assigned this Jan 13, 2023
@yuumasato yuumasato changed the title Fix link to NTP docs Update link to NTP docs Jan 13, 2023
Mab879
Mab879 approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Mab879 Mab879 merged commit f8b2131 into ComplianceAsCode:master Jan 13, 2023
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Jan 13, 2023
@yuumasato yuumasato deleted the update_NTP_chrony_link branch January 13, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels
Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Milestone
0.1.66
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yuumasato @Mab879