Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new rule configure_bashrc_tmux #10100

Merged
merged 8 commits into from
Jan 23, 2023

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • add new rule with tests, check and remediations
  • swap configure_bashrc_exec_tmux for configure_bashrc_tmux in rhel8/profiles/stig.profile

Rationale:

This aligns to the latest released RHEL8 STIG.

Review Hints:

  • check the latest STIG benchmark for definition of RHEL-08-020041
  • build the rhel8 product and test the rule if needed

@vojtapolasek vojtapolasek added New Rule Issues or pull requests related to new Rules. Update Profile Issues or pull requests related to Profiles updates. RHEL8 Red Hat Enterprise Linux 8 product related. STIG STIG Benchmark related. labels Jan 20, 2023
@vojtapolasek vojtapolasek added this to the 0.1.66 milestone Jan 20, 2023
@vojtapolasek vojtapolasek requested a review from a team as a code owner January 20, 2023 12:56
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions
Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
New content has different text for rule 'xccdf_org.ssgproject.content_rule_configure_bashrc_exec_tmux'.
--- xccdf_org.ssgproject.content_rule_configure_bashrc_exec_tmux
+++ xccdf_org.ssgproject.content_rule_configure_bashrc_exec_tmux
@@ -31,12 +31,6 @@
 [reference]:
 SRG-OS-000030-GPOS-00011
 
-[reference]:
-RHEL-08-020041
-
-[reference]:
-SV-230349r880737_rule
-
 [rationale]:
 Unlike bash itself, the tmux terminal multiplexer
 provides a mechanism to lock sessions after period of inactivity.

@yuumasato yuumasato self-assigned this Jan 20, 2023
vojtapolasek and others added 2 commits January 23, 2023 10:50
…g/console_screen_locking/configure_bashrc_tmux/rule.yml

Co-authored-by: Watson Yuuma Sato <wsato@redhat.com>
Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, just pending CI.

@codeclimate
Copy link

codeclimate bot commented Jan 23, 2023

Code Climate has analyzed commit c3a6ad5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.7% (0.0% change).

View more on Code Climate.

@openshift-ci
Copy link

openshift-ci bot commented Jan 23, 2023

@vojtapolasek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-rhcos4-high c3a6ad5 link true /test e2e-aws-rhcos4-high

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yuumasato
Copy link
Member

The CS9 test fails because the rule is not available for RHEL9.

@yuumasato yuumasato merged commit d232c16 into ComplianceAsCode:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Rule Issues or pull requests related to new Rules. RHEL8 Red Hat Enterprise Linux 8 product related. STIG STIG Benchmark related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants