Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New SLE 15 rule service_nftables_enabled #10113

Merged

Conversation

rumch-se
Copy link
Contributor

Description:

  • New SLE 15 rule which covers CIS recommendation 3.5.2.9 Ensure nftables service is enabled (Automated)

Rationale:

  • At the moment CIS profile for SLE 15 does not include this rule.

@rumch-se rumch-se requested a review from a team as a code owner January 23, 2023 12:44
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 23, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 23, 2023

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

sle15 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 self-assigned this Jan 23, 2023
@Mab879 Mab879 added New Rule Issues or pull requests related to new Rules. SLES SUSE Linux Enterprise Server product related. CIS CIS Benchmark related. labels Jan 23, 2023
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR; just one minor change.


prodtype: sle15

title: 'Verify nftables service is enabled'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: 'Verify nftables service is enabled'
title: 'Verify nftables Service Is Enabled'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of rules needs to be in title case.

@rumch-se
Copy link
Contributor Author

Hello @Mab879
I have made the proposed small change. (b98d058)
Have a nice day
Rumen

@codeclimate
Copy link

codeclimate bot commented Jan 24, 2023

Code Climate has analyzed commit b98d058 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.7% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 added this to the 0.1.67 milestone Jan 24, 2023
@Mab879
Copy link
Member

Mab879 commented Jan 25, 2023

/packit retest-failed

@Mab879
Copy link
Member

Mab879 commented Jan 25, 2023

The Automatus failures are expected due to the prodtype.

@Mab879 Mab879 merged commit 61ada81 into ComplianceAsCode:master Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. New Rule Issues or pull requests related to new Rules. SLES SUSE Linux Enterprise Server product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants