Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove utils/count_oval_objects.py #10133

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jan 27, 2023

Description:

Removes utils/count_oval_objects.py as it broken and not worth the time to fix it.

Rationale:

During the review of #10065 it was decided that removal was better than trying to fix this script.

The usefulness of the script is also questionable
@Mab879 Mab879 added the Infrastructure Our content build system label Jan 27, 2023
@Mab879 Mab879 added this to the 0.1.67 milestone Jan 27, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jan 27, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 27, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Mab879 Mab879 marked this pull request as ready for review January 27, 2023 16:00
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jan 27, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Jan 27, 2023

Code Climate has analyzed commit e74ed77 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.5% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Jan 30, 2023
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also agree that the benefit of fixing this script would be low it just counts types of OVAL objects used in an XCCDF file. I recall that it's a one-off script that was used once to determine priority of fixing OpenSCAP probes based on their usage in content.

The CI fail on Fedora Rawhide is caused by cmake segfault https://bugzilla.redhat.com/show_bug.cgi?id=2164654 and it isn't related to the changes in this PR.

@jan-cerny jan-cerny merged commit eea8148 into ComplianceAsCode:master Jan 30, 2023
@Mab879 Mab879 deleted the remove_count_oval_objects branch January 30, 2023 13:49
Mab879 added a commit to Mab879/content that referenced this pull request May 5, 2023
Mab879 added a commit to Mab879/content that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants