-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove utils/count_oval_objects.py #10133
Remove utils/count_oval_objects.py #10133
Conversation
The usefulness of the script is also questionable
Skipping CI for Draft Pull Request. |
Code Climate has analyzed commit e74ed77 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 49.5% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also agree that the benefit of fixing this script would be low it just counts types of OVAL objects used in an XCCDF file. I recall that it's a one-off script that was used once to determine priority of fixing OpenSCAP probes based on their usage in content.
The CI fail on Fedora Rawhide is caused by cmake segfault https://bugzilla.redhat.com/show_bug.cgi?id=2164654 and it isn't related to the changes in this PR.
The script was removed in ComplianceAsCode#10133
The script was removed in ComplianceAsCode#10133
Description:
Removes
utils/count_oval_objects.py
as it broken and not worth the time to fix it.Rationale:
During the review of #10065 it was decided that removal was better than trying to fix this script.