Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing SRG to aide_build_database rule (for master branch) #10150

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Add missing SRG to aide_build_database rule (for master branch) #10150

merged 2 commits into from
Feb 1, 2023

Conversation

vojtapolasek
Copy link
Collaborator

This is backport of PR #10136 into the master branch. Original description and rationale follows:

Description:

  • add correct SRG to rule aide_build_database
  • remove wrongly assigned SRG from package_aide_installed

Rationale:

Review Hints:

  • build RHEL7 or RHEL8 content
  • check the STIG guide and check the SRG reference of the rule aide_build_database

@vojtapolasek vojtapolasek added bugfix Fixes to reported bugs. RHEL9 Red Hat Enterprise Linux 9 product related. Update Rule Issues or pull requests related to Rules updates. RHEL8 Red Hat Enterprise Linux 8 product related. STIG STIG Benchmark related. labels Jan 31, 2023
@vojtapolasek vojtapolasek added this to the 0.1.67 milestone Jan 31, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Jan 31, 2023

Code Climate has analyzed commit f401ff7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.5% (0.0% change).

View more on Code Climate.

@Mab879
Copy link
Member

Mab879 commented Jan 31, 2023

/packit retest-failed

@marcusburghardt
Copy link
Member

/retest

@marcusburghardt marcusburghardt self-assigned this Feb 1, 2023
marcusburghardt
marcusburghardt approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@marcusburghardt marcusburghardt merged commit 10a025d into ComplianceAsCode:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusburghardt marcusburghardt marcusburghardt approved these changes

Assignees

@marcusburghardt marcusburghardt

Labels
bugfix Fixes to reported bugs. RHEL8 Red Hat Enterprise Linux 8 product related. RHEL9 Red Hat Enterprise Linux 9 product related. STIG STIG Benchmark related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Milestone
0.1.67
Development

Successfully merging this pull request may close these issues.

aide_build_database is missing SRG
3 participants
@vojtapolasek @Mab879 @marcusburghardt