Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove service_rngd_enabled from RHEL9 and RHEL8 STIG profiles #10153

Conversation

vojtapolasek
Copy link
Collaborator

Backport of #10152 into master branch.
Fixes: #10111
Original description and rationale follows:

Description:

  • remove rule from profiles
  • remove stigid references
  • remove the policy file for stig

Rationale:

Usefulness of rngd on RHEL 8.4+ is debatable, especially when using FIPS mode with STIG. Therefore, it was decided to remove this rule.

Review Hints:

  • diff the compiled profile with previous commit (build/rhelx/profiles/stig(_gui.|.)profile)

@vojtapolasek vojtapolasek added bugfix Fixes to reported bugs. RHEL9 Red Hat Enterprise Linux 9 product related. Update Profile Issues or pull requests related to Profiles updates. RHEL8 Red Hat Enterprise Linux 8 product related. STIG STIG Benchmark related. labels Feb 1, 2023
@vojtapolasek vojtapolasek added this to the 0.1.67 milestone Feb 1, 2023
@vojtapolasek vojtapolasek requested a review from a team as a code owner February 1, 2023 08:25
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Feb 1, 2023

Code Climate has analyzed commit c1a7b32 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.5% (0.0% change).

View more on Code Climate.

@marcusburghardt
Copy link
Member

/retest

@marcusburghardt marcusburghardt self-assigned this Feb 2, 2023
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This rule was already impacting packit tests.

@marcusburghardt marcusburghardt merged commit d6d2363 into ComplianceAsCode:master Feb 2, 2023
@yuumasato yuumasato added the backported-into-stabilization PRs which were cherry-picked during stabilization process. label Feb 7, 2023
@ggbecker ggbecker mentioned this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported-into-stabilization PRs which were cherry-picked during stabilization process. bugfix Fixes to reported bugs. RHEL8 Red Hat Enterprise Linux 8 product related. RHEL9 Red Hat Enterprise Linux 9 product related. STIG STIG Benchmark related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

service_rngd_enabled rule is failing after reboot
3 participants