Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve applicability of rule package_rear_installed (master branch) #10156

Merged

Conversation

vojtapolasek
Copy link
Collaborator

This is a port of #10144 into master branch. Original description and rationale follow:

Description:

Create appropriate platforms to fullfill the following:
Make the rule not applicable in following cases:

  • arch is s390x and RHEL <= 8.4
  • arch is aarch64 and RHEL or OL >= 9.0

Rationale:

  • the rear package is not available on some arches and RHEL / OL versions

Review Hints:

  • build the content
  • instantiate some RHEL (OL) machine on s390x / aarch64 machine
  • test that OVALs are applicable / not applicable in correct cases
  • do the same with Ansible - you can use the e8 Ansible playbook with --tag=package_rear_installed
  • tip: modify the /etc/os-release version_id line to simulate various distro versions

@vojtapolasek vojtapolasek added Oracle Linux Oracle Linux product related. RHEL9 Red Hat Enterprise Linux 9 product related. Update Rule Issues or pull requests related to Rules updates. RHEL8 Red Hat Enterprise Linux 8 product related. labels Feb 2, 2023
@vojtapolasek vojtapolasek added this to the 0.1.67 milestone Feb 2, 2023
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 self-assigned this Feb 2, 2023
@Mab879
Copy link
Member

Mab879 commented Feb 2, 2023

/packit test

@Mab879
Copy link
Member

Mab879 commented Feb 2, 2023

/retest

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase? That should fix the issues with packit tests.

the rule is not applicable if:
- architecture is S390x and RHEL is <= 8.4
- architecture is aarch64 and RHEL or OL >= 9.0

(cherry picked from commit 352082d)
change it in OVAL descriptions
rename the file so taht OS is in capital

(cherry picked from commit 4d47f60)
@codeclimate
Copy link

codeclimate bot commented Feb 3, 2023

Code Climate has analyzed commit 2a37e18 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.5% (0.0% change).

View more on Code Climate.

@vojtapolasek
Copy link
Collaborator Author

/retest

@vojtapolasek
Copy link
Collaborator Author

@Mab879 rebased and checks are passing.

@Mab879 Mab879 merged commit 6cc122a into ComplianceAsCode:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Oracle Linux Oracle Linux product related. RHEL8 Red Hat Enterprise Linux 8 product related. RHEL9 Red Hat Enterprise Linux 9 product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants