Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCP4 STIG: Cover SRG-APP-000297-CTR-000705 with a new rule oauth_logout_url_set #10187

Merged
merged 1 commit into from
Feb 21, 2023
Merged

OCP4 STIG: Cover SRG-APP-000297-CTR-000705 with a new rule oauth_logout_url_set #10187

merged 1 commit into from
Feb 21, 2023

Conversation

jhrozek
Copy link
Collaborator

@jhrozek jhrozek commented Feb 9, 2023

Description:

  • Adds a new rule oauth_logout_url_set that checks that the console is configured
    to redirect the user to a logout page

Rationale:

  • According to the STIG, users must have a clear way of clearing their credential

Review Hints:

  • Make sure the tests pass
  • compare the row in the autogenerated spreadsheet with this spreadsheet

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Start a new ephemeral environment with changes proposed in this pull request:

ocp4 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@jhrozek
Copy link
Collaborator Author

jhrozek commented Feb 9, 2023

/retest
cluster installs are having a bad day

@jhrozek jhrozek added OpenShift OpenShift product related. STIG STIG Benchmark related. labels Feb 9, 2023
@jhrozek
Copy link
Collaborator Author

jhrozek commented Feb 10, 2023

Related artifact: https://github.com/ComplianceAsCode/content/suites/10882614859/artifacts/549199083

@jhrozek
Copy link
Collaborator Author

jhrozek commented Feb 10, 2023

/retest

1 similar comment
@jhrozek
Copy link
Collaborator Author

jhrozek commented Feb 10, 2023

/retest

@jhrozek
Copy link
Collaborator Author

jhrozek commented Feb 13, 2023

@Vincent056 I think the remaining test failures are unrelated. PTAL

@marcusburghardt marcusburghardt added the New Rule Issues or pull requests related to new Rules. label Feb 20, 2023
@marcusburghardt marcusburghardt added this to the 0.1.67 milestone Feb 20, 2023
@marcusburghardt marcusburghardt self-assigned this Feb 20, 2023
@codeclimate
Copy link

codeclimate bot commented Feb 20, 2023

Code Climate has analyzed commit e86724f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 51.7% (0.0% change).

View more on Code Climate.

@jhrozek
Copy link
Collaborator Author

jhrozek commented Feb 20, 2023

scans just appeared to be slow
/retest

@jhrozek
Copy link
Collaborator Author

jhrozek commented Feb 20, 2023

To review, you can compare the SRG export with the current STIG draft

@marcusburghardt
Copy link
Member

/retest

@jhrozek
Copy link
Collaborator Author

jhrozek commented Feb 21, 2023

Since @rhmdnd acked the patches earlier and since then I only fixed blank lines at the end of files and all CI tests are passing I'm taking the liberty to merge the PR.

@jhrozek jhrozek merged commit 3a57bda into ComplianceAsCode:master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusburghardt marcusburghardt marcusburghardt left review comments

@rhmdnd rhmdnd rhmdnd approved these changes

@Vincent056 Vincent056 Awaiting requested review from Vincent056

Assignees

@marcusburghardt marcusburghardt

Labels
New Rule Issues or pull requests related to new Rules. OpenShift OpenShift product related. STIG STIG Benchmark related.
Projects
None yet
Milestone
0.1.67
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jhrozek @marcusburghardt @rhmdnd