Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten rule title #10196

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Conversation

jan-cerny
Copy link
Collaborator

@jan-cerny jan-cerny commented Feb 10, 2023

Rule titles should be brief. The very long rule title causes text overflows in HTML report and causes horizontal scrolling in SCAP Workbench.

Rule titles should be brief. The very long rule title causes text
overflows in HTML report and causes vertical scrolling in SCAP Workbench.
@jan-cerny jan-cerny added enhancement General enhancements to the project. Update Rule Issues or pull requests related to Rules updates. labels Feb 10, 2023
@jan-cerny jan-cerny added this to the 0.1.67 milestone Feb 10, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@marcusburghardt marcusburghardt self-assigned this Feb 10, 2023
…ion/rule.yml

Co-authored-by: Matthew Burket <m@tthewburket.com>
@jan-cerny
Copy link
Collaborator Author

good to know thx

I think we can have a check that enforces the case and also maximum length

@codeclimate
Copy link

codeclimate bot commented Feb 13, 2023

Code Climate has analyzed commit 1951f18 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 51.7% (0.0% change).

View more on Code Climate.

@marcusburghardt
Copy link
Member

good to know thx

I think we can have a check that enforces the case and also maximum length

That would be great. I would be happy to review this proposal.

@marcusburghardt marcusburghardt dismissed Mab879’s stale review February 13, 2023 10:26

Changes proposed by Matthew were accepted. Thanks

@marcusburghardt marcusburghardt merged commit 4d831b4 into ComplianceAsCode:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancements to the project. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants