Update test scenarios for accounts_password_last_change_is_in_past #10213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Start a new ephemeral environment with changes proposed in this pull request: rhel8 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Some CI tests use containers, and those container might not have commands like passwd. One approach would be to install the package in the test scenarios, but the name of the package that brings up the passwd command differs among distros. In favor of simplicity, entries were manually created in the /etc/shadow file. This is sufficient for the context of this rule.
marcusburghardt
force-pushed
the
accounts_password_last_change_is_in_past_container
branch
from
517f069
to
e7a3d27
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
Code Climate has analyzed commit e7a3d27 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 51.7% (0.0% change). View more on Code Climate. |
vojtapolasek
approved these changes
Feb 16, 2023
marcusburghardt
deleted the
accounts_password_last_change_is_in_past_container
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Some CI tests use containers, and those container might not have commands like
passwd.One approach would be to install the package in the test scenarios, but the name of the package that brings up the
passwdcommand differs among distros.In favor of simplicity, entries were manually created in the /etc/shadow file.
This is sufficient for the context of this rule.
Rationale:
Review Hints:
Automatus Tests should pass in CI tests.