-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cap_system_chroot capability to Automatus podman container #10246
add cap_system_chroot capability to Automatus podman container #10246
Conversation
The mypy tests are failing on F37 and Rawhide. I think this is not related to changes proposed in this PR. |
…omatus in container mode recent changes made it impossible to login to a podman container with sshd running without giving this capability to it
584a61b
to
a9dd2a7
Compare
Code Climate has analyzed commit a9dd2a7 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 51.7% (0.0% change). View more on Code Climate. |
@vojtapolasek I tried to reproduce the steps in the review hints, I'm on the latest RHEL 8.8 VM, but I got stuck unexpectedly, I got this weird error:
It's unrelated to this PR because it happens also with the current master branch, but I was wondering if I can verify it. Have you ever encountered a problem like that? |
@jan-cerny I have encountered this as well. You have to install python38-jinja2 and python38-pyyaml and use python3.8 to run automatus. |
@vojtapolasek Thanks for the hint! I missed the Python 3.8 fact. Now I was able to sucessfully reproduce the problem in RHEL 8.8 VM and I confirm that this patch fixes this problem. My concern now is: Is it somewhere tracked that Automatus works only with a non-default version of Python on RHEL 8? Specifically Python 3.8? If not, can you file a ticket about it? |
@jan-cerny I have created thiss issue to track it: #10267 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your report
Description:
Rationale:
recent changes made it impossible to login to a podman container with sshd running without giving this capability to it
Review Hints: