Fix Automatus on Python 3.6 #10281
Merged
Fix Automatus on Python 3.6 #10281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
The os.path.dirname(__file__) on Python 3.6 seems to return an relative path and on newer Pythons it returns an absolute path. This commit ensures that the JINJA_MACROS_DIRECTORY is always an abssolute path. This is needed because the AbsolutePathFileSystemLoader for Jinja will throw a TemplateNotFound if the template path is not absolute
|
Code Climate has analyzed commit 5d526d6 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 51.7% (0.0% change). View more on Code Climate. |
|
It's probably not the |
matejak
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR ensures that
JINJA_MACROS_DIRECTORYinssg/constants.pyis always an ABS path.Fixes #10267
Rationale:
The os.path.dirname(file) on Python 3.6 seems to return an relative path and on newer Pythons it returns an absolute path. This commit ensures that the JINJA_MACROS_DIRECTORY is always an abssolute path. This is needed because the AbsolutePathFileSystemLoader for Jinja will throw a TemplateNotFound if the template path is not absolute
Review Hints:
To reproduce the error use a RHEL 8.7 machine to run the tests as described in #10267.