Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: ssg_test_suite: RuleResult __eq__ #10365

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

maage
Copy link
Contributor

@maage maage commented Mar 25, 2023

Description:

Simple copy paste error.

Rationale:

Should be obvious.

Review Hints:

Probably is not used as results have been wrong. I have not tested it as fix is obvious.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Mar 25, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 25, 2023

Hi @maage. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Mar 25, 2023

Code Climate has analyzed commit d7f6858 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 51.9% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Mar 28, 2023
@Mab879 Mab879 added this to the 0.1.68 milestone Mar 28, 2023
@Mab879 Mab879 added the Test Suite Update in Test Suite. label Mar 28, 2023
@Mab879 Mab879 merged commit f7a2c8b into ComplianceAsCode:master Mar 28, 2023
@maage maage deleted the ruleresult-1 branch March 29, 2023 07:29
@maage
Copy link
Contributor Author

maage commented Mar 29, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. Test Suite Update in Test Suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants