Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLE improve kernel module disabled rule #10368

Conversation

teacup-on-rockingchair
Copy link
Contributor

Description:

  • Merge kernel module disabled template for SLE to use designated files for better readability and support

Rationale:

  • Use same approach as in RedHat and Oracle platforms

Merge kernel module disabled template for SLE to use designated files for better readability and support
@openshift-ci
Copy link

openshift-ci bot commented Mar 27, 2023

Hi @teacup-on-rockingchair. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Mar 27, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Mar 27, 2023

Code Climate has analyzed commit 96ab6cf and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 51.9% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt self-assigned this Mar 27, 2023
@marcusburghardt marcusburghardt added this to the 0.1.68 milestone Mar 27, 2023
@marcusburghardt marcusburghardt added the SLES SUSE Linux Enterprise Server product related. label Mar 27, 2023
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@marcusburghardt marcusburghardt added Ansible Ansible remediation update. OVAL OVAL update. Related to the systems assessments. Bash Bash remediation update. labels Mar 27, 2023
@marcusburghardt marcusburghardt merged commit 540f529 into ComplianceAsCode:master Mar 27, 2023
29 checks passed
@jan-cerny jan-cerny added the Update Rule Issues or pull requests related to Rules updates. label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ansible Ansible remediation update. Bash Bash remediation update. needs-ok-to-test Used by openshift-ci bot. OVAL OVAL update. Related to the systems assessments. SLES SUSE Linux Enterprise Server product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants