Disable logrotate timer in ensure_logrotate_activated tests #10375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed since ComplianceAsCode#10343 added test for the logrotate timer
|
Start a new ephemeral environment with changes proposed in this pull request: rhel8 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit ef388fe and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 51.9% (0.0% change). View more on Code Climate. |
jan-cerny
merged commit 2f04dcc
into
ComplianceAsCode:stabilization-v0.1.67
26 of 29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is needed since #10343 added an OVAL check for the logrotate systemd timer OR'ed with the cron check.
We may want to adjust the OVAL (and this test) if we want to limit the checking of the timer to OSs that have it, seems to RHEL 9+, I have not checked Ubuntu or SUSE.
Rationale:
Fixes #10371
Reviewer Hints:
The logrotate timer is only in RHEL 9.