Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete rule SLES-15-040280 #10383

Merged
merged 2 commits into from
Mar 31, 2023
Merged

delete rule SLES-15-040280 #10383

merged 2 commits into from
Mar 31, 2023

Conversation

svet-se
Copy link
Contributor

@svet-se svet-se commented Mar 28, 2023

Description:

  • Delete rule sshd_disable_compression

Rationale:

  • Accoring DISA recommendations Version 1, Release 9 from 26 January 2023 about SLE 15 STIG - "SLES-15-040280 - Deleted rule as it is not applicable to SLES 15."

@svet-se svet-se requested a review from a team as a code owner March 28, 2023 13:40
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Mar 28, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 28, 2023

Hi @svet-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label Mar 28, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 added SLES SUSE Linux Enterprise Server product related. STIG STIG Benchmark related. labels Mar 28, 2023
@Mab879 Mab879 added this to the 0.1.68 milestone Mar 28, 2023
@mildas
Copy link
Contributor

mildas commented Mar 29, 2023

/packit retest-failed

marcusburghardt
marcusburghardt requested changes Mar 29, 2023
View reviewed changes
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one point about the cce removal.

linux_os/guide/services/ssh/ssh_server/sshd_disable_compression/rule.yml Outdated Show resolved Hide resolved
@marcusburghardt marcusburghardt self-assigned this Mar 31, 2023
marcusburghardt
marcusburghardt approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@codeclimate
Copy link

codeclimate bot commented Mar 31, 2023

Code Climate has analyzed commit f0eb2b3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 51.8% (0.0% change).

View more on Code Climate.

@svet-se
Copy link
Contributor Author

svet-se commented Mar 31, 2023

@marcusburghardt FYI I'm working for SUSE (with @rumch-se) and will contribute to this project. Please advise how can I be added to ComplianceAsCode/suse-maintainers.

@marcusburghardt
Copy link
Member

@marcusburghardt FYI I'm working for SUSE (with @rumch-se) and will contribute to this project. Please advise how can I be added to ComplianceAsCode/suse-maintainers.

Welcome @svet-se . First, if you are not already there, I would like to invite you to join us in Gitter. There you will find most of the contributors and the maintainers.

Regarding the criteria to get merge rights, please take a look in our Governance policies:
https://complianceascode.readthedocs.io/en/latest/manual/developer/01_introduction.html#governance

You can approach us if you have any question.

@marcusburghardt
Copy link
Member

Overriding CODEOWNERS since a SUSE approver is not currently available.

@marcusburghardt marcusburghardt merged commit 27bf7c8 into ComplianceAsCode:master Mar 31, 2023
29 checks passed
@svet-se svet-se deleted the rule-sles-15-040280 branch April 3, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusburghardt marcusburghardt marcusburghardt approved these changes

Assignees

@marcusburghardt marcusburghardt

Labels
needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. STIG STIG Benchmark related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.68
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@svet-se @mildas @marcusburghardt @Mab879