Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No remediation warning for fapolicy_default_deny #10433

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

mildas
Copy link
Contributor

@mildas mildas commented Apr 6, 2023

Description:

fapolicy_default_deny doesn't have remediation because the rule requires to employ deny-all policy and allowing only whitelisted software. Automatic remediation could cause system non-administrable.

Rationale:

To inform users, remediation is missing intentionally.

@mildas mildas requested a review from Mab879 April 6, 2023 09:51
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one minor revision. Thanks!

@codeclimate
Copy link

codeclimate bot commented Apr 11, 2023

Code Climate has analyzed commit 5637dfc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.4% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 added this to the 0.1.68 milestone Apr 11, 2023
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Apr 11, 2023
@Mab879 Mab879 merged commit 3297b87 into ComplianceAsCode:master Apr 13, 2023
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants