Modify SLE remediation for ensure_logrotate_activated

[teacup-on-rockingchair]

Description:

• For logrotate enabled rule, in SLE context, prefer timer service over cron schedule

Rationale:

• In SLE platforms it is preferred to utilize logrotate timer service for log rotation functionality. OVAL check remains sam, and will accept cron-based configuration, but in case of missing scheduled timer, timer service is preferred over cron.

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)

Fedora Testing Environment

Oracle Linux 8 Environment

[github-actions]

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff

bash remediation for rule 'xccdf_org.ssgproject.content_rule_ensure_logrotate_activated' differs.
--- xccdf_org.ssgproject.content_rule_ensure_logrotate_activated
+++ xccdf_org.ssgproject.content_rule_ensure_logrotate_activated
@@ -2,13 +2,16 @@
 if [ ! -f /.dockerenv ] && [ ! -f /run/.containerenv ]; then
 
 LOGROTATE_CONF_FILE="/etc/logrotate.conf"
+
 CRON_DAILY_LOGROTATE_FILE="/etc/cron.daily/logrotate"
+
 
 # daily rotation is configured
 grep -q "^daily$" $LOGROTATE_CONF_FILE|| echo "daily" >> $LOGROTATE_CONF_FILE
 
 # remove any line configuring weekly, monthly or yearly rotation
 sed -i '/^\s*\(weekly\|monthly\|yearly\).*$/d' $LOGROTATE_CONF_FILE
+
 
 # configure cron.daily if not already
 if ! grep -q "^[[:space:]]*/usr/sbin/logrotate[[:alnum:][:blank:][:punct:]]*$LOGROTATE_CONF_FILE$" $CRON_DAILY_LOGROTATE_FILE; then

[codeclimate]

Code Climate has analyzed commit 8f09957 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.4% (0.0% change).

View more on Code Climate.