Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

products/anolis23: supports Anolis OS 23 #10548

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

rain-Qing
Copy link
Contributor

@rain-Qing rain-Qing commented May 10, 2023

Signed-off-by: YuQing yyq0391@163.com
Signed-off-by: YiLin.Li YiLin.Li@linux.alibaba.com

Description:
products/anolis8: supports Anolis OS 23

Rationale:

  • OpenSCAP now supports many products. Anolis OS 23 ( https://openanolis.cn/ ) is an upstream native community-oriented independent selection based on the theory of operating system hierarchy classification by the OpenAnolis community; natively building a full-stack hardware and software collaborative next generation OS version.So I want to add the produce/anolis23 into OpenSCAP.

  • Fixes products: Support Anolis OS 23 #10538

@openshift-ci
Copy link

openshift-ci bot commented May 10, 2023

Hi @rain-Qing. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label May 10, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@rain-Qing rain-Qing force-pushed the anolis23 branch 2 times, most recently from 9a3f109 to 314cadf Compare May 10, 2023 09:03
@Mab879 Mab879 added the New Product Issues or pull requests related to new Products. label May 10, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Used by openshift-ci bot. label May 10, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Used by openshift-ci bot. label May 11, 2023
@Mab879
Copy link
Member

Mab879 commented May 15, 2023

Please take a look at the CI failures. The utils/fix_rules.py should be in fixing the error reported by CI.

@rain-Qing
Copy link
Contributor Author

rain-Qing commented May 16, 2023

Please take a look at the CI failures. The utils/fix_rules.py should be in fixing the error reported by CI.

Thanks for your advice, I have repaired the code again and submitted it.

@Mab879 Mab879 added this to the 0.1.69 milestone Jun 5, 2023
@Mab879 Mab879 self-assigned this Jun 5, 2023
@rain-Qing
Copy link
Contributor Author

@Mab879 I have resolved the conflict and resubmitted.

Please review it again. Thank you.

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please take look at my comments.

products/anolis23/transforms/constants.xslt Outdated Show resolved Hide resolved
products/anolis23/transforms/table-style.xslt Outdated Show resolved Hide resolved
products/anolis23/transforms/xccdf-apply-overlay-stig.xslt Outdated Show resolved Hide resolved
@rain-Qing
Copy link
Contributor Author

@Mab879
Thank you for your comments. I have processed and pushed again.
Please review it again. Thank you.

@rain-Qing rain-Qing requested a review from Mab879 June 29, 2023 07:50
@rain-Qing rain-Qing force-pushed the anolis23 branch 2 times, most recently from d845958 to ad35f95 Compare June 30, 2023 06:47
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a couple paths are still wrong.

Once these are fixed this should be ready to merge.

products/anolis23/transforms/xccdf2table-cce.xslt Outdated Show resolved Hide resolved
@Mab879 Mab879 added the Highlight This PR/Issue should make it to the featured changelog. label Jul 5, 2023
Signed-off-by: YuQing <yyq0391@163.com>
Signed-off-by: YiLin.Li <YiLin.Li@linux.alibaba.com>
@rain-Qing
Copy link
Contributor Author

@Mab879
Thank you for your review and comments.
Now I see that the CI/CD test has passed. (links and screenshots of some of the test results are below)
Is there anything else I need to do before the merger?

test
image

@codeclimate
Copy link

codeclimate bot commented Jul 6, 2023

Code Climate has analyzed commit 29f415f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.5% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 merged commit 2f1286b into ComplianceAsCode:master Jul 6, 2023
33 checks passed
This was referenced Aug 24, 2023
@rain-Qing rain-Qing deleted the anolis23 branch January 25, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Highlight This PR/Issue should make it to the featured changelog. needs-ok-to-test Used by openshift-ci bot. New Product Issues or pull requests related to new Products.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

products: Support Anolis OS 23
3 participants