Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes of cron package/service for SLE 12/15 #10549

Merged

Conversation

rumch-se
Copy link
Contributor

Description:

  • Changes in profiles and rules related to cron package/service for SLE 12/15

Rationale:

  • The rules package_cron_installed and service_cron_enabled are not correct.

@rumch-se rumch-se requested a review from a team as a code owner May 10, 2023 13:37
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label May 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 10, 2023

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions
Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
New datastream adds OCIL for rule 'xccdf_org.ssgproject.content_rule_package_cron_installed'.

@codeclimate
Copy link

codeclimate bot commented May 10, 2023

Code Climate has analyzed commit aad66f0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.4% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 added this to the 0.1.68 milestone May 10, 2023
@Mab879 Mab879 added SLES SUSE Linux Enterprise Server product related. Update Rule Issues or pull requests related to Rules updates. Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. labels May 10, 2023
@rumch-se
Copy link
Contributor Author

Hello @teacup-on-rockingchair
The change was done
Rumen

@teacup-on-rockingchair teacup-on-rockingchair merged commit f84884d into ComplianceAsCode:master Jun 15, 2023
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. Update Profile Issues or pull requests related to Profiles updates. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants