Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix into the rule sysctl_kernel_randomize_va_space #10555

Merged

Conversation

rumch-se
Copy link
Contributor

Description:

  • A fix of the SLE 15/15 rule sysctl_kernel_randomize_va_space

Rationale:

  • The fix requires changes into sysctl template because in SUSE configuration files have the following locations: /run/sysctl.d/
    /etc/sysctl.d/
    /usr/local/lib/sysctl.d/
    /usr/lib/sysctl.d/
    /lib/sysctl.d/
    /etc/sysctl.conf

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label May 12, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 12, 2023

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@yuumasato yuumasato self-assigned this May 16, 2023
Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rumch-se Hi, the change looks good to me.
I just requested one small change as it affects RHEL in an unwated way.

shared/templates/sysctl/ansible.template Show resolved Hide resolved
shared/templates/sysctl/oval.template Outdated Show resolved Hide resolved
shared/templates/sysctl/oval.template Outdated Show resolved Hide resolved
@rumch-se
Copy link
Contributor Author

Hello @yuumasato
I have implemented the proposed changes in oval.template
Have a nice day
Rumen

shared/templates/sysctl/oval.template Outdated Show resolved Hide resolved
shared/templates/sysctl/oval.template Outdated Show resolved Hide resolved
shared/templates/sysctl/oval.template Outdated Show resolved Hide resolved
@yuumasato yuumasato added this to the 0.1.68 milestone May 23, 2023
@jan-cerny jan-cerny modified the milestones: 0.1.68, 0.1.69 May 29, 2023
@rumch-se
Copy link
Contributor Author

Hello @teacup-on-rockingchair, @yuumasato and @jan-cerny
Would be possible this PR to me merged to the master ?

Have a nice day
Rumen

@jan-cerny
Copy link
Collaborator

@rumch-se Sure, it will be possible after you address the problems that @yuumasato mentioned above.

@jan-cerny jan-cerny added Ansible Ansible remediation update. OVAL OVAL update. Related to the systems assessments. Bash Bash remediation update. Update Rule Issues or pull requests related to Rules updates. labels Jun 27, 2023
@rumch-se
Copy link
Contributor Author

Hello @jan-cerny
I think that I made the expected changes via my last commit.
May you check?
Have a nice day
Rumen

@openshift-merge-robot openshift-merge-robot added needs-rebase Used by openshift-ci bot. and removed needs-rebase Used by openshift-ci bot. labels Jul 16, 2023
@marcusburghardt
Copy link
Member

The CI errors are probably related to the last commit, which was a merge commit. I believe the intention was to rebase the PR instead of merging the master into it. Could you take a look, please?

@vojtapolasek vojtapolasek modified the milestones: 0.1.69, 0.1.70 Jul 18, 2023
shared/templates/sysctl/oval.template Outdated Show resolved Hide resolved
shared/templates/sysctl/oval.template Show resolved Hide resolved
@openshift-merge-robot openshift-merge-robot added the needs-rebase Used by openshift-ci bot. label Jul 18, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Used by openshift-ci bot. label Jul 19, 2023
Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the update of the SLE STIG reference file seems out of place.

shared/references/disa-stig-sle15-v1r10-xccdf-manual.xml Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Jul 21, 2023

Code Climate has analyzed commit ae9eb19 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.2% (0.0% change).

View more on Code Climate.

@yuumasato yuumasato merged commit 4bfaefb into ComplianceAsCode:master Jul 21, 2023
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ansible Ansible remediation update. Bash Bash remediation update. needs-ok-to-test Used by openshift-ci bot. OVAL OVAL update. Related to the systems assessments. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants