Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused test code #10558

Merged
merged 2 commits into from
May 15, 2023
Merged

Unused test code #10558

merged 2 commits into from
May 15, 2023

Conversation

maage
Copy link
Contributor

@maage maage commented May 14, 2023

Description:

Two unused test code.

Rationale:

These just confuse and they might end up maintained without any need.

Review Hints:

% git grep send_files_remote
% git grep SHARED/sysctl

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label May 14, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 14, 2023

Hi @maage. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented May 14, 2023

Code Climate has analyzed commit 807b625 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.4%.

View more on Code Climate.

@maage
Copy link
Contributor Author

maage commented May 14, 2023

For failing: testing-farm:centos-stream-8-x86_64 — Tests failed ...
Reason seems to be Maximum test time '30m' exceeded.
I assume it is unrelated issue. It might help if there was timestamp in each logged line to see where time is spent. Now it is only per phase.
Also that should not take 30 mins.

@marcusburghardt marcusburghardt added the Test Suite Update in Test Suite. label May 15, 2023
@marcusburghardt marcusburghardt added this to the 0.1.68 milestone May 15, 2023
@marcusburghardt marcusburghardt added the enhancement General enhancements to the project. label May 15, 2023
@jan-cerny jan-cerny self-assigned this May 15, 2023
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice discovery!

I have seen that these aren't used.

@jan-cerny jan-cerny merged commit 61600a7 into ComplianceAsCode:master May 15, 2023
32 checks passed
@maage maage deleted the unused-1 branch May 18, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancements to the project. needs-ok-to-test Used by openshift-ci bot. Test Suite Update in Test Suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants