Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests applicablity for ol8 product #10570

Merged
merged 1 commit into from
May 16, 2023

Conversation

Xeicker
Copy link
Contributor

@Xeicker Xeicker commented May 15, 2023

Description:

  • There were a few tests part of rules in stig profile which were marked as applicable to ol8 but shouldn't. This address those issues

Rationale:

  • When testing ol8 stig profile with automatus, there were some false positives. Marking tests correctly as nonapplicable to address that

Review Hints:

  • All these changed tests should be marked as not applicable when testing with automatus in OL8

There were a few tests part of rules in stig profile which were marked
as applicable to ol8 but shouldn't. This address those issues

Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label May 15, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 15, 2023

Hi @Xeicker. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented May 15, 2023

Code Climate has analyzed commit ef9c98e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.4% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 added this to the 0.1.68 milestone May 15, 2023
@vojtapolasek vojtapolasek self-assigned this May 16, 2023
@vojtapolasek
Copy link
Collaborator

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels May 16, 2023
Copy link
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vojtapolasek vojtapolasek merged commit 328eac5 into ComplianceAsCode:master May 16, 2023
33 checks passed
@jan-cerny jan-cerny added the Test Suite Update in Test Suite. label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Used by openshift-ci bot. Test Suite Update in Test Suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants