fix: ensure_fedora_gpgkey_installed/bash: use bash_package_install

[maage]

Description:

Use common macro bash_package_install to package installs.

Rationale:

Even if there is platform limiter and so on I still think it is better to use the macro.

Review Hints:

Simple change, the rule remediation should be tested.

[openshift-ci]

Hi @maage. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

fedora (from CTF) Environment (using Fedora as testing environment)

Fedora Testing Environment

Oracle Linux 8 Environment

[github-actions]

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff

bash remediation for rule 'xccdf_org.ssgproject.content_rule_ensure_fedora_gpgkey_installed' differs.
--- xccdf_org.ssgproject.content_rule_ensure_fedora_gpgkey_installed
+++ xccdf_org.ssgproject.content_rule_ensure_fedora_gpgkey_installed
@@ -1,5 +1,7 @@
 
-dnf install -y gpg
+if ! rpm -q --quiet "gpg" ; then
+ dnf install -y "gpg"
+fi
 
 fedora_version=$(grep -oP '[[:digit:]]+' /etc/redhat-release)

[codeclimate]

Code Climate has analyzed commit d16b720 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.4% (0.0% change).

View more on Code Climate.

[Mab879]

Automatus failures are expected since this rule is not applicable on CS8 and CS9.

[maage]

Thanks