Replace grep command with ansible find #10579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Start a new ephemeral environment with changes proposed in this pull request: rhel8 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
teacup-on-rockingchair
force-pushed
the
drop_cmdline_in_audit_ansible_for_find
branch
from
c9fad54
to
e2a6c07
Compare
Replace usage of grep commandline in favour of find builtin module in ansible, in order to: - prevent ansible remediation to fail in case of missing matches - in general it is better to use ansible modules than command lines
teacup-on-rockingchair
force-pushed
the
drop_cmdline_in_audit_ansible_for_find
branch
from
e2a6c07
to
bf79767
Compare
|
Code Climate has analyzed commit bf79767 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 52.4% (0.0% change). View more on Code Climate. |
marcusburghardt
added
Ansible
marcusburghardt
approved these changes
May 17, 2023
marcusburghardt
merged commit e751902
into
ComplianceAsCode:master
29 of 32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Replace usage of grep commandline in favour of find builtin module in ansible, in order to:
Rationale: