Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests in sshd_lineinfile template #10595

Merged

Conversation

Xeicker
Copy link
Contributor

@Xeicker Xeicker commented May 19, 2023

Description:

  • Change passing tests so they are based on comment.fail.sh

Rationale:

  • In some cases the testing environment had existing non compliant configurations which made some test fail when they were expected to pass. This ensures that doesn't happen

Review Hints:

  • Automatus results should be enough as this adresses only tests results
  • Only make sure this change makes sense

In some cases the testing environment had existing non compliant
configurations which made some test fail when they were expected to
pass. This ensures that doesn't happen

Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@openshift-ci
Copy link

openshift-ci bot commented May 19, 2023

Hi @Xeicker. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label May 19, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented May 19, 2023

Code Climate has analyzed commit d01898c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.5% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt added the Test Suite Update in Test Suite. label May 22, 2023
@marcusburghardt marcusburghardt added this to the 0.1.68 milestone May 22, 2023
@marcusburghardt marcusburghardt self-assigned this May 22, 2023
@marcusburghardt marcusburghardt merged commit 343e73a into ComplianceAsCode:master May 22, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. Test Suite Update in Test Suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants