Refactor the scapval test #10611
Refactor the scapval test #10611
Conversation
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
I propose to disregard CodeClimate suggestion, as the current layout allows us to easily add more conditions to the PASS case. |
tests/run_scapval.py
Outdated
| return False | ||
|
|
||
|
|
||
| def format_requirement_feedback(req_id, message): |
There was a problem hiding this comment.
I think it should be named print_requirement_feedback as its main goal is to print something, it doesn't return a formatted string.
- make it explicit that requirement ID refers to scapval - unify the print formatting code
|
Code Climate has analyzed commit 48f45ab and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 52.5% (0.0% change). View more on Code Climate. |
marcusburghardt
added
the
refactoring
|
@jan-cerny , I believe it can already be merged, correct? |
|
@marcusburghardt Yes, it looks like the CI has already finished! |
Description:
Make the code more explicit/readable. Successor of #10451
Rationale:
Nothing in particular, make the code readable and extensible.
Review Hints:
The functionality should be the same.