Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pass aging rules to not ignore empty pass #10633

Merged

Conversation

Xeicker
Copy link
Contributor

@Xeicker Xeicker commented May 24, 2023

Description:

  • Update regex in accounts_password_set_max_life_existing & accounts_password_set_min_life_existing so empty passwords are not ignored

Rationale:

  • Empty string can be a password and should be treated the same as any other

Review Hints:

  • The introduced tests should cover this new behavior

Rules accounts_password_set_max_life_existing &
accounts_password_set_min_life_existing were ignoring empty strings
as when evaluating passwords. This is wrong as empty string is also a
password and should be treated the same as any other, at least in these
cases

Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label May 24, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 24, 2023

Hi @Xeicker. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented May 24, 2023

Code Climate has analyzed commit 9f5b073 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.5% (0.0% change).

View more on Code Climate.

Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Xeicker

@marcusburghardt marcusburghardt self-assigned this May 25, 2023
@marcusburghardt marcusburghardt added Update Rule Issues or pull requests related to Rules updates. OVAL OVAL update. Related to the systems assessments. labels May 25, 2023
@marcusburghardt marcusburghardt added this to the 0.1.68 milestone May 25, 2023
@marcusburghardt marcusburghardt merged commit f418fed into ComplianceAsCode:master May 25, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. OVAL OVAL update. Related to the systems assessments. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants