Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning to rsyslog_remote_tls_cacert #10676

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Add warning to rsyslog_remote_tls_cacert #10676

merged 1 commit into from
Jun 5, 2023

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jun 2, 2023

Description:

As this rule does not have remediations.

Rationale:

Fix #10668

@Mab879
Add warning to rsyslog_remote_tls_cacert
cfd7329 
As this rule does not have remediations
@Mab879 Mab879 added the bugfix Fixes to reported bugs. label Jun 2, 2023
@Mab879 Mab879 added this to the 0.1.68 milestone Jun 2, 2023
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Jun 2, 2023

Code Climate has analyzed commit cfd7329 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.8% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Jun 2, 2023
@jan-cerny
Copy link
Collaborator

/packit retest-failed

@Mab879 Mab879 mentioned this pull request Jun 2, 2023
Merged
jan-cerny
jan-cerny approved these changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI fail on rawhide isn't related to this PR but is caused by an issue of the target problem
Run dnf update -y
Config error: Parsing file "/etc/dnf/dnf.conf" failed: Parsing file '/etc/dnf/dnf.conf' failed: IniParser: Missing section header at line 1
Error: Process completed with exit code 1.

@jan-cerny jan-cerny merged commit 7c78c29 into ComplianceAsCode:master Jun 5, 2023
31 of 32 checks passed
@Mab879 Mab879 deleted the fix_10668 branch June 5, 2023 12:52
@jan-cerny jan-cerny added the Update Rule Issues or pull requests related to Rules updates. label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusburghardt marcusburghardt marcusburghardt approved these changes

@jan-cerny jan-cerny jan-cerny approved these changes

Assignees

@jan-cerny jan-cerny

Labels
bugfix Fixes to reported bugs. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Milestone
0.1.68
Development

Successfully merging this pull request may close these issues.

Rule rsyslog_remote_tls_cacert is missing a warning
3 participants
@Mab879 @jan-cerny @marcusburghardt