Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of anssi profile for SLE 12/15 #10702

Conversation

rumch-se
Copy link
Contributor

@rumch-se rumch-se commented Jun 8, 2023

Description:

  • Include in anssi profile for SLE 12/15 the rule set_password_hashing_min_rounds_logindefs and exclude accounts_password_pam_unix_rounds_system_auth and accounts_password_pam_unix_rounds_password_auth

Rationale:

  • The included rule is supported by SLE 12/15, excluded not

@rumch-se rumch-se requested a review from a team as a code owner June 8, 2023 14:31
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jun 8, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2023

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 added SLES SUSE Linux Enterprise Server product related. Update Profile Issues or pull requests related to Profiles updates. ANSSI ANSSI Benchmark related. labels Jun 9, 2023
Copy link
Contributor

@teacup-on-rockingchair teacup-on-rockingchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Mab879 Mab879 added this to the 0.1.69 milestone Jun 15, 2023
@Mab879
Copy link
Member

Mab879 commented Jun 15, 2023

@rumch-se if you rebase this PR that should resolve the CMake lint issue that is causing the CI failures.

@codeclimate
Copy link

codeclimate bot commented Jun 21, 2023

Code Climate has analyzed commit 74209dd and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.9% (0.0% change).

View more on Code Climate.

@teacup-on-rockingchair teacup-on-rockingchair merged commit 3ef60b8 into ComplianceAsCode:master Jun 21, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ANSSI ANSSI Benchmark related. needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants