Add a Playbook name to Ansible Playbooks #10713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-cerny
added
Ansible
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
In the stabilization GitHub Action CI runs all the tests ansible-playbook-per-profile-ansible-lint-check-.* fail due to a missing name. This can be easily fixed by assigning a name to all the playbooks. Addressing: name[play]: All plays should be named.
|
Code Climate has analyzed commit ba03b48 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 20.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 52.8% (0.0% change). View more on Code Climate. |
|
The testing-farm:centos-stream-9-x86_64 failure appears to be unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In the stabilization GitHub Action CI runs all the tests ansible-playbook-per-profile-ansible-lint-check-.* fail due to a missing name. This can be easily fixed by assigning a name to all the playbooks.
Addressing:
name[play]: All plays should be named.
Rationale:
docs/release_process.md says:
Review Hints:
review the results of ansible-playbook-per-profile-ansible-lint-check CTest tests
This PR has been backported to the
stabilization-v0.1.68by #10712.