Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform package variables for firewalld and iptables #10740

Conversation

teacup-on-rockingchair
Copy link
Contributor

Description:

  • Limit conflicting services for firewall functionality with platform package rule's clauses

Rationale:

  • Add platform package definitions for firewalld and iptables
  • Add platform package clause for firewalld related rules
  • Add platform package clause for iptables related rules

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jun 21, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 21, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 added this to the 0.1.69 milestone Jun 21, 2023
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Jun 21, 2023
@codeclimate
Copy link

codeclimate bot commented Jun 22, 2023

Code Climate has analyzed commit 7172933 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.8% (-0.1% change).

View more on Code Climate.

@teacup-on-rockingchair teacup-on-rockingchair marked this pull request as ready for review June 26, 2023 06:52
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jun 26, 2023
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have built the rhel9 product and I have seen that these rules have a #package_firewalld reference to the CPE entry.

@jan-cerny jan-cerny merged commit 0fbcf6b into ComplianceAsCode:master Jun 26, 2023
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants