Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the most important links to a better place #10745

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

jan-cerny
Copy link
Collaborator

This increases visibility of the stuff that we are doing.

This increases visibility of the stuff that we are doing.
@jan-cerny jan-cerny added the Documentation Update in project documentation. label Jun 23, 2023
@jan-cerny jan-cerny added this to the 0.1.69 milestone Jun 23, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Jun 23, 2023

Code Climate has analyzed commit d9adbd1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.8% (0.0% change).

View more on Code Climate.

@@ -261,15 +266,6 @@ decided to change the name of the project to `ComplianceAsCode`, in order to avo
We envision that the future will be format-agnostic. That's why opted for an
abstraction instead of using XCCDF for the input format.

## Further reading

The SSG homepage is [https://www.open-scap.org/security-policies/scap-security-guide/](https://www.open-scap.org/security-policies/scap-security-guide/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe keeping the link to the web page is still relevant. I think you can transform this section into a web site dedicated section for example.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That web page is very outdated, it doesn't even mention the rename that our project did long time ago, frequently mentions RHEL 6 and it doesn't add any useful information on top of readthedocs or this readme.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that Open-SCAP.org page is very outdated, leaving it out is not too big of an issue.

@Mab879 Mab879 self-assigned this Jun 23, 2023
@Mab879
Copy link
Member

Mab879 commented Jun 23, 2023

I approve, I will leave this open for day to get more feedback.

@Mab879 Mab879 merged commit 661884a into ComplianceAsCode:master Jun 26, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Update in project documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants