Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes for Ubuntu #10755

Merged
merged 4 commits into from
Jun 27, 2023
Merged

Various fixes for Ubuntu #10755

merged 4 commits into from
Jun 27, 2023

Conversation

dodys
Copy link
Contributor

@dodys dodys commented Jun 26, 2023

Description:

  • wireless_disable_interfaces : Improve Ubuntu remediation
  • set_ufw_loopback_traffic : Fix logic in SCE script
  • bash macros: pam_faillock: Improve bash to consider different configurations in Ubuntu

Rationale:

  • Various small fixes to improve Ubuntu checks and remediation

@dodys dodys added Ubuntu Ubuntu product related. CIS CIS Benchmark related. labels Jun 26, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Jun 26, 2023

Code Climate has analyzed commit ea77544 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.8% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny added the Bash Bash remediation update. label Jun 27, 2023
@jan-cerny jan-cerny self-assigned this Jun 27, 2023
@jan-cerny jan-cerny added this to the 0.1.69 milestone Jun 27, 2023
jan-cerny
jan-cerny approved these changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI fail on Rawhide is caused by OpenSCAP/openscap#1995 and isn't related to the contents of this PR.

@jan-cerny jan-cerny merged commit e61329d into ComplianceAsCode:master Jun 27, 2023
32 of 34 checks passed
@dodys dodys deleted the misc-fixes branch July 20, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-cerny jan-cerny jan-cerny approved these changes

Assignees

@jan-cerny jan-cerny

Labels
Bash Bash remediation update. CIS CIS Benchmark related. Ubuntu Ubuntu product related.
Projects
None yet
Milestone
0.1.69
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dodys @jan-cerny