Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from "use_pam_wheel_for_su" to "use_pam_wheel_group_for_su" for RHEL 8 and 9 #10762

Conversation

wokis
Copy link
Contributor

@wokis wokis commented Jun 28, 2023

Description:

Switch from use_pam_wheel_for_su to use_pam_wheel_group_for_su for the CIS profile and RHEL 8/9 product.

Rationale:

Ubuntu already uses use_pam_wheel_group_for_su for CIS. This PR aligns RHEL 8/9 to the same CIS benchmark.

@wokis wokis requested a review from a team as a code owner June 28, 2023 06:40
@openshift-ci
Copy link

openshift-ci bot commented Jun 28, 2023

Hi @wokis. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jun 28, 2023
@github-actions
Copy link

github-actions bot commented Jun 28, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@wokis wokis force-pushed the cis_rhel8_rhel9_use_pam_wheel_group_for_su branch from 4babebf to ecea3a2 Compare June 28, 2023 07:29
@Mab879 Mab879 added this to the 0.1.69 milestone Jun 28, 2023
@Mab879 Mab879 added RHEL Red Hat Enterprise Linux product related. CIS CIS Benchmark related. Update Profile Issues or pull requests related to Profiles updates. labels Jun 28, 2023
@Mackemania
Copy link
Contributor

The fail on Fedora Rawhide is caused by OpenSCAP/openscap#1995 and isn't related to the contents of this PR.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Used by openshift-ci bot. label Jul 6, 2023
@wokis wokis force-pushed the cis_rhel8_rhel9_use_pam_wheel_group_for_su branch from ecea3a2 to 9633c1a Compare July 7, 2023 11:37
@wokis wokis requested review from a team as code owners July 7, 2023 11:37
@wokis wokis force-pushed the cis_rhel8_rhel9_use_pam_wheel_group_for_su branch from 9633c1a to e953390 Compare July 7, 2023 11:46
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Used by openshift-ci bot. label Jul 7, 2023
@wokis wokis force-pushed the cis_rhel8_rhel9_use_pam_wheel_group_for_su branch from e953390 to 550dcfc Compare July 7, 2023 11:53
@Mab879
Copy link
Member

Mab879 commented Jul 7, 2023

It looks like the current CI failures are valid. Please take look.

@wokis wokis force-pushed the cis_rhel8_rhel9_use_pam_wheel_group_for_su branch from 550dcfc to 786216c Compare July 7, 2023 19:27
@marcusburghardt marcusburghardt self-assigned this Jul 10, 2023
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@codeclimate
Copy link

codeclimate bot commented Jul 10, 2023

Code Climate has analyzed commit 786216c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.5% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt merged commit 7bb9c44 into ComplianceAsCode:master Jul 10, 2023
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. RHEL Red Hat Enterprise Linux product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants