-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service_apport_disabled: depend on apport being installed #10805
service_apport_disabled: depend on apport being installed #10805
Conversation
Hi @candrews. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
You will need to make an mirror edit to shared/applicability/package.yml
to get this to work, but that should be an easy fix.
service_apport_disabled is only applicable if apport is installed.
c4c0987
to
9ad9b5d
Compare
Code Climate has analyzed commit 9ad9b5d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.5% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Waving the Rawhide failures as they are not related to this PR.
Description:
service_apport_disabled is only applicable if apport is installed.
Rationale:
service_apport_disabled is only applicable if apport is installed.