Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no_rsh_trust_files: depend on rsh-server being installed #10809

Merged
merged 1 commit into from
Jul 28, 2023
Merged

no_rsh_trust_files: depend on rsh-server being installed #10809

merged 1 commit into from
Jul 28, 2023

Conversation

candrews
Copy link
Contributor

@candrews candrews commented Jul 6, 2023

Description:

no_rsh_trust_files: depend on rsh-server being installed

Rationale:

no_rsh_trust_files is only applicable if rsh-server is installed.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jul 6, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 6, 2023

Hi @candrews. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Mab879
Mab879 requested changes Jul 6, 2023
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Please take look the build failures and my comment.

linux_os/guide/services/obsolete/r_services/no_rsh_trust_files/rule.yml Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@marcusburghardt
Copy link
Member

The CI errors seems legit. The components mapping should be updated.

@marcusburghardt marcusburghardt added Update Rule Issues or pull requests related to Rules updates. CPE-AL CPE Applicability Language labels Jul 7, 2023
@marcusburghardt marcusburghardt added this to the 0.1.69 milestone Jul 7, 2023
@marcusburghardt
Copy link
Member

@candrews the error in CI tests is this:

107/307 Test #108: components ............................................................***Failed    5.96 sec
Rule 'no_rsh_trust_files' must be assigned to component 'rsh', because it uses the package['rsh-server'] platform.

It should be simple to fix by including the rule in proper component file.
https://github.com/ComplianceAsCode/content/tree/master/components

@vojtapolasek vojtapolasek modified the milestones: 0.1.69, 0.1.70 Jul 18, 2023
@marcusburghardt
Copy link
Member

@candrews this PR is almost ready to be merged. The pending issue should be simple to be fixed.

@candrews
no_rsh_trust_files: depend on rsh-server being installed
66cc43a 
no_rsh_trust_files is only applicable if rsh-server is installed.

Signed-off-by: Craig Andrews <candrews@integralblue.com>
@candrews
Copy link
Contributor Author

this PR is almost ready to be merged. The pending issue should be simple to be fixed.

I've made that change and updated this PR - thank you for this information and the reminder to get this done 👍

@codeclimate
Copy link

codeclimate bot commented Jul 26, 2023

Code Climate has analyzed commit 66cc43a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.2% (0.0% change).

View more on Code Climate.

marcusburghardt
marcusburghardt approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@marcusburghardt
Copy link
Member

@Mab879 it is up to you. The packit tests can be waived in this case.

Mab879
Mab879 approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well!

@Mab879
Copy link
Member

Mab879 commented Jul 28, 2023

/packit rebuild-failed

@Mab879 Mab879 merged commit b3c80e5 into ComplianceAsCode:master Jul 28, 2023
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

@marcusburghardt marcusburghardt marcusburghardt approved these changes

Assignees

@Mab879 Mab879

Labels
CPE-AL CPE Applicability Language needs-ok-to-test Used by openshift-ci bot. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Milestone
0.1.70
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@candrews @marcusburghardt @Mab879 @vojtapolasek