Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RHEL 7 STIG to v3r11 #10821

Merged
merged 7 commits into from
Jul 12, 2023
Merged

Update RHEL 7 STIG to v3r11 #10821

merged 7 commits into from
Jul 12, 2023

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jul 11, 2023

Description:

Updates the RHEL 7 STIG to V3R11.

Rationale:

Ensure the STIG is updated.

@Mab879 Mab879 added Update Profile Issues or pull requests related to Profiles updates. RHEL7 Red Hat Enterprise Linux 7 product related. STIG STIG Benchmark related. labels Jul 11, 2023
@Mab879 Mab879 added this to the 0.1.69 milestone Jul 11, 2023
@Mab879 Mab879 requested a review from a team as a code owner July 11, 2023 19:03
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Jul 11, 2023

Code Climate has analyzed commit 77000c1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.5% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt self-assigned this Jul 12, 2023
marcusburghardt
marcusburghardt approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. I only put a comment recommending to deprecate the account_emergency_expire_date rule, but this is out of scope in this PR. Could you take a look on this and, if agreed, open another PR please?

...e/system/accounts/accounts-restrictions/account_expiration/account_temp_expire_date/rule.yml
@@ -45,6 +45,7 @@ references:
srg: SRG-OS-000123-GPOS-00064,SRG-OS-000002-GPOS-00002
stigid@ol7: OL07-00-010271
stigid@ol8: OL08-00-020000
stigid@rhel7: RHEL-07-010271
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The account_emergency_expire_date and account_temp_expire_date rules are basically the same with minimal changes in the rule description. It can be done in a separate PR, but we should deprecate the account_emergency_expire_date rule.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That might be good idea. DISA has kept changing the wording around these a few times so that is reason for both rules.

@marcusburghardt marcusburghardt merged commit 10a2611 into ComplianceAsCode:master Jul 12, 2023
32 of 34 checks passed
@Mab879 Mab879 deleted the rhel7_stig_v3r11 branch July 12, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusburghardt marcusburghardt marcusburghardt approved these changes

Assignees

@marcusburghardt marcusburghardt

Labels
RHEL7 Red Hat Enterprise Linux 7 product related. STIG STIG Benchmark related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.69
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mab879 @marcusburghardt