Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rules for CIS OCP Section 1.4 #10840

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

rhmdnd
Copy link
Collaborator

@rhmdnd rhmdnd commented Jul 13, 2023

Now that we have control files for the new OpenShift 1.4.0 profile, let's start filling in the sections with rules that implement it.

@rhmdnd rhmdnd added OpenShift OpenShift product related. CIS CIS Benchmark related. labels Jul 13, 2023
@rhmdnd rhmdnd requested a review from jhrozek July 13, 2023 20:25
@github-actions
Copy link

github-actions bot commented Jul 13, 2023

Start a new ephemeral environment with changes proposed in this pull request:

ocp4 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@marcusburghardt
Copy link
Member

I know the PR is simple but could you provide a description, please? This is useful for less technical audience.
Even a small context is always welcome. Thanks

@marcusburghardt marcusburghardt added this to the 0.1.69 milestone Jul 14, 2023
@yuumasato yuumasato self-assigned this Jul 14, 2023
@github-actions
Copy link

github-actions bot commented Jul 14, 2023

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
New content has different text for rule 'xccdf_org.ssgproject.content_rule_rbac_debug_role_protects_pprof'.
--- xccdf_org.ssgproject.content_rule_rbac_debug_role_protects_pprof
+++ xccdf_org.ssgproject.content_rule_rbac_debug_role_protects_pprof
@@ -35,9 +35,6 @@
 [reference]:
 1.3.1
 
-[reference]:
-1.4.1
-
 [rationale]:
 Profiling allows for the identification of specific performance bottlenecks.
 It generates a significant amount of program data that could potentially be

@vojtapolasek vojtapolasek modified the milestones: 0.1.69, 0.1.70 Jul 18, 2023
Now that we have control files for the new OpenShift 1.4.0 profile,
let's start filling in the sections with rules that implement it.
@rhmdnd
Copy link
Collaborator Author

rhmdnd commented Jul 19, 2023

/test e2e-aws-ocp4-cis
/test e2e-aws-ocp4-cis-node

Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lance, LGTM.

@codeclimate
Copy link

codeclimate bot commented Jul 19, 2023

Code Climate has analyzed commit ea19775 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.2% (0.0% change).

View more on Code Climate.

@yuumasato
Copy link
Member

Rawhide is failing on import imp, and the automatus tests fail becaues the rule is for ocp4.

@yuumasato yuumasato merged commit a658703 into ComplianceAsCode:master Jul 19, 2023
32 of 36 checks passed
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. OpenShift OpenShift product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants