Use distributed product properties in Automatus #10878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatus needs to start using distributed product properties.
Loading only `product.yml` will not obtain all variables
that appear in rule YAML files.
Addressing:
```
[jcerny@fedora scap-security-guide{master}]$ tests/automatus.py rule --libvirt qemu:///system ssgts_rhel8 --remediate-using ansible --datastream build/ssg-rhel8-ds.xml dir_perms_world_writable_system_owned_group
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2023-07-19-1524/test_suite.log
ERROR - Terminating due to error: Error loading a Rule from /home/jcerny/work/git/scap-security-guide/linux_os/guide/system/permissions/files/dir_perms_world_writable_system_owned_group/rule.yml: 'auid' is undefined.
WARNING - Nothing has been tested!
```
Fixes: ComplianceAsCode#10866
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit e9c3aee and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.2% (0.0% change). View more on Code Climate. |
vojtapolasek
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Hello @jan-cerny and thank you for this fix. I tested this fix on many tests which started failing and it works indeed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatus needs to start using distributed product properties. Loading only
product.ymlwill not obtain all variables that appear in rule YAML files.Addressing:
Fixes: #10866