Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A correction in the rule pam_disable_automatic_configuration #10902

Conversation

rumch-se
Copy link
Contributor

Description:

  • The correction corrects the recommendation pam_disable_automatic_configuration

Rationale:

  • At the moment after the build in the resulting remediation files (bash/ansible) we have first the rule pam_disable_automatic_configuration and after this we have the rule package_pam_apparmor_installed, instead of opposite order. There is a dependency between both rules because pam_disable_automatic_configuration removes soft links, but these links are created during the execution of the rule package_pam_apparmor_installed. With this correction the rule pam_disable_automatic_configuration will not make changes in our system when the module pam_apparmor is not installed.

@openshift-ci
Copy link

openshift-ci bot commented Jul 25, 2023

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jul 25, 2023
@github-actions
Copy link

github-actions bot commented Jul 25, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@jan-cerny
Copy link
Collaborator

/packit retest-failed

@marcusburghardt marcusburghardt added SLES SUSE Linux Enterprise Server product related. CPE-AL CPE Applicability Language labels Aug 2, 2023
@marcusburghardt marcusburghardt added this to the 0.1.70 milestone Aug 2, 2023
@rumch-se
Copy link
Contributor Author

Hello @teacup-on-rockingchair
I have implemented the proposed change and I think that this PR could be merged.
Rumen

@codeclimate
Copy link

codeclimate bot commented Aug 21, 2023

Code Climate has analyzed commit 5231e94 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.3% (0.0% change).

View more on Code Climate.

@marcusburghardt
Copy link
Member

The current errors in CI tests are known issues unrelated to this PR.

@marcusburghardt marcusburghardt merged commit 1d6f21c into ComplianceAsCode:master Aug 21, 2023
32 of 34 checks passed
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Oct 12, 2023
@marcusburghardt marcusburghardt self-assigned this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CPE-AL CPE Applicability Language needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants