Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include RHEL indentifiers in logrotate related rules #10904

Merged
merged 5 commits into from
Jul 28, 2023

Conversation

marcusburghardt
Copy link
Member

@marcusburghardt marcusburghardt commented Jul 26, 2023

Description:

There is a CIS requirement for RHEL regarding logrotate configuration.
It is a manual requirement and therefore the rules are not included in the profile.
However, the were mentioned in related_rules and identifiers were included to make them easier to be user in tailoring files.

Rationale:

Better CIS control files for RHEL
This PR will unblock the #10796

@marcusburghardt marcusburghardt added RHEL Red Hat Enterprise Linux product related. CIS CIS Benchmark related. labels Jul 26, 2023
@marcusburghardt marcusburghardt added this to the 0.1.70 milestone Jul 26, 2023
@marcusburghardt marcusburghardt requested a review from a team as a code owner July 26, 2023 10:23
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Jul 26, 2023

Code Climate has analyzed commit 171287f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.2% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Jul 26, 2023
@Mab879
Copy link
Member

Mab879 commented Jul 26, 2023

/packit rebuild-failed

@mildas
Copy link
Contributor

mildas commented Jul 28, 2023

/packit retest-failed

2 similar comments
@mildas
Copy link
Contributor

mildas commented Jul 28, 2023

/packit retest-failed

@mildas
Copy link
Contributor

mildas commented Jul 28, 2023

/packit retest-failed

@Mab879 Mab879 merged commit a045e07 into ComplianceAsCode:master Jul 28, 2023
33 of 34 checks passed
@marcusburghardt marcusburghardt deleted the logrotate_cce branch August 2, 2023 07:02
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. RHEL Red Hat Enterprise Linux product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants