Update ssh stig HMACS and Ciphers allowed in OL8 STIG

[Xeicker]

Description:

• Update HMAC algorithms selection for OL8 STIG
• Add new cipher selection in sshd_approved_ciphers in a similar approach as in taken in HMACs
• Apply this new selection in OL8 STIG

Rationale:

• This is to keep up to date OL8 STIG with DISA's V1R7

Note: The Cipher update also applies to RHEL8, let me know if you want me to apply it there also

[openshift-ci]

Hi @Xeicker. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)

Fedora Testing Environment

Oracle Linux 8 Environment

[github-actions]

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff

New content has different text for rule 'xccdf_org.ssgproject.content_rule_harden_sshd_macs_openssh_conf_crypto_policy'.
--- xccdf_org.ssgproject.content_rule_harden_sshd_macs_openssh_conf_crypto_policy
+++ xccdf_org.ssgproject.content_rule_harden_sshd_macs_openssh_conf_crypto_policy
@@ -10,7 +10,7 @@
 To check that Crypto Policies settings are configured correctly, ensure that
 /etc/crypto-policies/back-ends/openssh.config contains the following
 line and is not commented out:
-MACs hmac-sha2-512,hmac-sha2-256
+MACs 'xccdf_org.ssgproject.content_value_sshd_approved_macs'
 
 [warning]:
 The system needs to be rebooted for these changes to take effect.

OCIL for rule 'xccdf_org.ssgproject.content_rule_harden_sshd_macs_openssh_conf_crypto_policy' differs.
--- ocil:ssg-harden_sshd_macs_openssh_conf_crypto_policy_ocil:questionnaire:1
+++ ocil:ssg-harden_sshd_macs_openssh_conf_crypto_policy_ocil:questionnaire:1
@@ -1,6 +1,6 @@
 To verify if the OpenSSH client uses defined MACs in the Crypto Policy, run:
 $ grep -i macs /etc/crypto-policies/back-ends/openssh.config
 and verify that the line matches:
-MACs hmac-sha2-512,hmac-sha2-256
+MACs 
       Is it the case that Crypto Policy for OpenSSH client is not configured correctly?
       
New content has different text for rule 'xccdf_org.ssgproject.content_rule_harden_sshd_macs_opensshserver_conf_crypto_policy'.
--- xccdf_org.ssgproject.content_rule_harden_sshd_macs_opensshserver_conf_crypto_policy
+++ xccdf_org.ssgproject.content_rule_harden_sshd_macs_opensshserver_conf_crypto_policy
@@ -10,7 +10,7 @@
 To check that Crypto Policies settings are configured correctly, ensure that
 /etc/crypto-policies/back-ends/opensshserver.config contains the following
 text and is not commented out:
--oMACS=hmac-sha2-512,hmac-sha2-256,hmac-sha2-512-etm@openssh.com,hmac-sha2-256-etm@openssh.com
+-oMACS='xccdf_org.ssgproject.content_value_sshd_approved_macs'
 
 [warning]:
 The system needs to be rebooted for these changes to take effect.

OCIL for rule 'xccdf_org.ssgproject.content_rule_harden_sshd_macs_opensshserver_conf_crypto_policy' differs.
--- ocil:ssg-harden_sshd_macs_opensshserver_conf_crypto_policy_ocil:questionnaire:1
+++ ocil:ssg-harden_sshd_macs_opensshserver_conf_crypto_policy_ocil:questionnaire:1
@@ -1,6 +1,6 @@
 To verify if the OpenSSH server uses defined MACs in the Crypto Policy, run:
 $ grep -Po '(-oMACs=\S+)' /etc/crypto-policies/back-ends/opensshserver.config
 and verify that the line matches:
--oMACS=hmac-sha2-512,hmac-sha2-256,hmac-sha2-512-etm@openssh.com,hmac-sha2-256-etm@openssh.com
+-oMACS=
       Is it the case that Crypto Policy for OpenSSH Server is not configured correctly?
       

[mildas]

/packit retest-failed

[mildas]

/packit retest-failed

[codeclimate]

Code Climate has analyzed commit f873f68 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.2% (0.0% change).

View more on Code Climate.

[freddieRv]

Changes LGTM. Thanks for the efforts @Xeicker

[marcusburghardt]

Thank you @Xeicker . I will take a look on RHEL8 STIG and likely update there too in another PR. Thanks again for this.