Remove CIS reference from image policy webhook rule #10932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While updating the CIS profile to support 1.4.0, we implemented more rules to ensure image configuration is setup properly, which superseded the general advice we had for configuring image provenance. This commit removes the CIS reference from the general_configure_imagepolicywebhook rule since that rule is no longer included in the CIS profile in favor of: ocp-allowed-registries ocp-allowed-registries-for-import ocp-insecure-registries ocp-insecure-allowed-registries-for-import
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit a5b8bf7 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.2% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While updating the CIS profile to support 1.4.0, we implemented more
rules to ensure image configuration is setup properly, which superseded
the general advice we had for configuring image provenance.
This commit removes the CIS reference from the
general_configure_imagepolicywebhook rule since that rule is no longer
included in the CIS profile in favor of:
ocp-allowed-registries
ocp-allowed-registries-for-import
ocp-insecure-registries
ocp-insecure-allowed-registries-for-import