Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rawhide Build #10953

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Fix Rawhide Build #10953

merged 2 commits into from
Aug 7, 2023

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Aug 3, 2023

Description:

  • Fix Rawhide build
  • Splits base build requirements into a new file
  • Is backwards compatible since requirements.txt includes requirements-base.txt.

Rationale:

Make it easier during reviews.

The commit changing the workflow should be reverted once 3.12 is more stable.

@Mab879 Mab879 added the Infrastructure Our content build system label Aug 3, 2023
@Mab879 Mab879 added this to the 0.1.70 milestone Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Aug 4, 2023

Code Climate has analyzed commit 17ee3f1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.2% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Aug 7, 2023
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen that the CI on Rawhide passes and that the tests work as expected.

@jan-cerny jan-cerny merged commit 4dd7ccb into ComplianceAsCode:master Aug 7, 2023
34 checks passed
@Mab879 Mab879 deleted the build_reqs branch August 7, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants